fix init image at creation #759
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
switftshader artifact needs to be refreshed |
We need to create the cvk_command_image_init with a valid context. Otherwise we can have a race condition between the destruction of queue and commands being deleted in the executor thread.
rjodinchr
force-pushed
the
pr/fix-init-image-at-creation
branch
from
8908894 to
085672d
Compare
|
Can you re-trigger the failing bot? It's the first time I'm seeing that error. I wonder if it happens just very rarely. I'm not able to reproduce on my machine. That may be something we just want to filter in the test to avoid flakyness I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to create the cvk_command_image_init with a valid context. Otherwise we can have a race condition between the destruction of queue and commands being deleted in the executor thread.